Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steps: make SetProperty property renderable #3157

Merged
merged 2 commits into from May 1, 2017

Conversation

noc0lour
Copy link
Contributor

there is no reason we can't have value a renderable, make setting properties more flexible.

  • I have created a file in the master/buildbot/newsfragment directory (and read the README.txt in that directory)

@mention-bot
Copy link

@noc0lour, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tardyp, @jvlomax and @sa2ajj to be potential reviewers.

@@ -0,0 +1 @@
``value`` argument in SetPropery is now renderable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value was already renderable. I think you mean property.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, true, I'll fix that.

@codecov
Copy link

codecov bot commented Apr 27, 2017

Codecov Report

Merging #3157 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3157      +/-   ##
==========================================
+ Coverage   88.06%   88.06%   +<.01%     
==========================================
  Files         314      314              
  Lines       33046    33047       +1     
==========================================
+ Hits        29101    29102       +1     
  Misses       3945     3945
Impacted Files Coverage Δ
master/buildbot/steps/master.py 91.78% <100%> (ø) ⬆️
master/buildbot/steps/cmake.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb26e17...5067969. Read the comment docs.

@tardyp
Copy link
Member

tardyp commented Apr 30, 2017

@noc0lour I've fixed the newsfragment myself

@tardyp tardyp merged commit 97f43d3 into buildbot:master May 1, 2017
@noc0lour
Copy link
Contributor Author

noc0lour commented May 1, 2017

Thanks. I had that lying around somewhere but forgot to push it, apparently

@tardyp
Copy link
Member

tardyp commented May 1, 2017

well, it is just two clicks away using github UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants