Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Tutorial docs fixes #3159

Merged
merged 3 commits into from May 8, 2017
Merged

[WIP] Tutorial docs fixes #3159

merged 3 commits into from May 8, 2017

Conversation

nazarewk
Copy link
Contributor

So i am going through buildbot tutorial and updating docs on the way, still work in progress.

  • I have created a file in the master/buildbot/newsfragment directory (and read the README.txt in that directory)
  • I have updated the appropriate documentation

@mention-bot
Copy link

@nazarewk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @lsblakk, @rutsky and @benallard to be potential reviewers.

@codecov
Copy link

codecov bot commented Apr 28, 2017

Codecov Report

Merging #3159 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3159      +/-   ##
==========================================
- Coverage   88.06%   88.05%   -0.01%     
==========================================
  Files         314      317       +3     
  Lines       33046    33146     +100     
==========================================
+ Hits        29101    29187      +86     
- Misses       3945     3959      +14
Impacted Files Coverage Δ
master/buildbot/steps/cmake.py 100% <0%> (ø) ⬆️
master/buildbot/configurators/__init__.py 91.66% <0%> (ø)
master/buildbot/configurators/janitor.py 95.74% <0%> (ø)
master/buildbot/monkeypatches/twisted9127.py 36.36% <0%> (ø)
master/buildbot/interfaces.py 98.93% <0%> (+0.01%) ⬆️
master/buildbot/www/auth.py 95.61% <0%> (+0.24%) ⬆️
master/buildbot/config.py 98.68% <0%> (+0.27%) ⬆️
master/buildbot/monkeypatches/__init__.py 87.09% <0%> (+1.38%) ⬆️
master/buildbot/steps/mswin.py 100% <0%> (+3.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb26e17...fab205a. Read the comment docs.

@@ -259,7 +259,7 @@ To use this you will need to install an additional package or two to your virtua
cd
cd tmp/buildbot
source sandbox/bin/activate
easy_install pycrypto
easy_install cryptography
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you replace easy_install with pip ?
there is a need for a pip install -U pip in the first place

@tardyp
Copy link
Member

tardyp commented May 8, 2017

thanks!

@tardyp tardyp merged commit 08bf81b into buildbot:master May 8, 2017
@nazarewk nazarewk deleted the docs-fixes branch May 23, 2017 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants