Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support auth token _get_commit_msg #3683

Merged
merged 5 commits into from Oct 17, 2017
Merged

Support auth token _get_commit_msg #3683

merged 5 commits into from Oct 17, 2017

Conversation

anish
Copy link
Contributor

@anish anish commented Oct 9, 2017

#3443 introduced the _get_commit_msg function, that interacts with the github api. This breaks the use of github event hook on any GitHub instances that enforce authentication. Add support for auth token

@tardyp
Copy link
Member

tardyp commented Oct 9, 2017

looks good. need to fix unit tests.

@anish
Copy link
Contributor Author

anish commented Oct 9, 2017

@tardyp working on it, I'm seeing 50 odd unrelated failures locally, need to fix the venv first

@codecov
Copy link

codecov bot commented Oct 17, 2017

Codecov Report

Merging #3683 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3683      +/-   ##
==========================================
+ Coverage   88.44%   88.44%   +<.01%     
==========================================
  Files         323      323              
  Lines       33967    33976       +9     
==========================================
+ Hits        30043    30051       +8     
- Misses       3924     3925       +1
Impacted Files Coverage Δ
master/buildbot/www/hooks/github.py 95.23% <100%> (+0.11%) ⬆️
master/buildbot/worker/docker.py 79.48% <0%> (-0.52%) ⬇️
master/buildbot/process/builder.py 84.44% <0%> (-0.11%) ⬇️
master/buildbot/steps/shell.py 97.45% <0%> (ø) ⬆️
master/buildbot/worker/hyper.py 89.38% <0%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93fc96d...cddf978. Read the comment docs.

@anish
Copy link
Contributor Author

anish commented Oct 17, 2017

@tardyp all done

@tardyp
Copy link
Member

tardyp commented Oct 17, 2017

great job! thanks!

@tardyp tardyp merged commit 40ba12d into buildbot:master Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants