Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make python setup.py test do something useful #408

Merged
merged 3 commits into from May 12, 2012

Conversation

msabramo
Copy link
Contributor

No description provided.

@djmitche
Copy link
Member

Nice work!

@djmitche djmitche merged commit 2949eb9 into buildbot:master May 12, 2012
@tomprince
Copy link
Member

This makes deploying on non-networked machines difficult. See http://trac.buildbot.net/ticket/2369

@djmitche
Copy link
Member

@msabramo can you take a look at the bug and let us know what you think is best?

@msabramo
Copy link
Contributor Author

I have an idea I'm experimenting with...

msabramo added a commit to msabramo/buildbot that referenced this pull request Sep 18, 2012
with relevant commands/options such as "test", "trial", or
"--help-commands".

That lets people continue to use `python setup.py test`, for example, to
run the test suite, while not forcing setuptools_trial to be there for
egg_info, sdist, install, etc.

Fixes buildbotGH-408, Trac-2369
@msabramo
Copy link
Contributor Author

@djmitche I think that e6a8071 will solve that bug while also still allowing python setup.py test to work.

If there are still significant difficulties, then it probably makes sense to just remove the setup_requires stuff. Like Tom said in the Trac ticket, it's just a testing nicety.

djmitche pushed a commit that referenced this pull request Sep 18, 2012
with relevant commands/options such as "test", "trial", or
"--help-commands".

That lets people continue to use `python setup.py test`, for example, to
run the test suite, while not forcing setuptools_trial to be there for
egg_info, sdist, install, etc.

Fixes GH-408, Trac-2369
thinkski pushed a commit to kuna-systems/buildbot that referenced this pull request Sep 10, 2014
with relevant commands/options such as "test", "trial", or
"--help-commands".

That lets people continue to use `python setup.py test`, for example, to
run the test suite, while not forcing setuptools_trial to be there for
egg_info, sdist, install, etc.

Fixes buildbotGH-408, Trac-2369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants