Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display owners instead of owner in the UI #4657

Merged
merged 1 commit into from Mar 14, 2019
Merged

Conversation

tardyp
Copy link
Member

@tardyp tardyp commented Mar 13, 2019

owners also reflects the owners from changes

owners also reflects the owners from changes
@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #4657 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4657   +/-   ##
=======================================
  Coverage   88.47%   88.47%           
=======================================
  Files         323      323           
  Lines       33670    33670           
=======================================
  Hits        29789    29789           
  Misses       3881     3881

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8333b53...ee1f853. Read the comment docs.

@YngveNPettersen
Copy link
Contributor

You might want to check other users/setters of "owner"/"owners" as well, for example in the ForcedScheduler

@tardyp
Copy link
Member Author

tardyp commented Mar 14, 2019

You might want to check other users/setters of "owner"/"owners" as well, for example in the ForcedScheduler

I did, and it should work as far as I read the code

@tardyp tardyp merged commit 19417a1 into buildbot:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants