www: Use local link: dependencies
#4849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p12tic
force-pushed
the
www-use-local-link-dependencies
branch
from
69621ba
to
db92820
Compare
Codecov Report
@@ Coverage Diff @@
## master #4849 +/- ##
=======================================
Coverage 88.67% 88.67%
=======================================
Files 329 329
Lines 34080 34080
=======================================
Hits 30222 30222
Misses 3858 3858Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue that #4813 tried to address, this time in a more maintainable and convenient way. Turns out that yarn has an undocumented support for link: dependency type which is effectively a symlink. This is exactly what we need to prevent stale dependencies.
The feature this PR relies on is not accidentally exposed behavior that could go away anytime soon as there's been an accepted RFC to add it: yarnpkg/rfcs#34.
I've opened yarnpkg/website#969 to document this behavior.