Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.8 support #5063

Merged
merged 4 commits into from Nov 24, 2019
Merged

Python 3.8 support #5063

merged 4 commits into from Nov 24, 2019

Conversation

yan12125
Copy link
Contributor

@yan12125 yan12125 commented Nov 4, 2019 •
edited

Contributor Checklist:

  • I have updated the unit tests
  • I have created a file in the master/buildbot/newsfragments directory (and read the README.txt in that directory)
  • I have updated the appropriate documentation

For now I only make tests pass. Further actions like adding trove classifiers to setup.py or a news fragment declaring Python 3.8 support are up to you.

@codecov
Copy link

codecov bot commented Nov 4, 2019 •
edited

Codecov Report

Merging #5063 into master will increase coverage by 0.2%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #5063     +/-   ##
=========================================
+ Coverage   89.01%   89.22%   +0.2%     
=========================================
  Files         332      332             
  Lines       35211    36014    +803     
=========================================
+ Hits        31344    32132    +788     
- Misses       3867     3882     +15
Impacted Files Coverage Δ
master/buildbot/changes/bitbucket.py 95.87% <87.5%> (-0.76%) ⬇️
master/buildbot/process/users/users.py 58.13% <0%> (-0.69%) ⬇️
master/buildbot/master.py 85.1% <0%> (-0.67%) ⬇️
master/buildbot/util/__init__.py 94.21% <0%> (-0.63%) ⬇️
master/buildbot/status/builder.py 39.3% <0%> (-0.35%) ⬇️
master/buildbot/process/buildrequestdistributor.py 98.02% <0%> (-0.33%) ⬇️
worker/buildbot_worker/commands/fs.py 80.12% <0%> (-0.25%) ⬇️
master/buildbot/steps/python_twisted.py 78.64% <0%> (-0.23%) ⬇️
master/buildbot/steps/package/rpm/rpmbuild.py 87.67% <0%> (-0.17%) ⬇️
master/buildbot/steps/python.py 94.69% <0%> (-0.1%) ⬇️
... and 183 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4d0c8f...7e7c32e. Read the comment docs.

@yan12125 yan12125 marked this pull request as ready for review November 4, 2019 07:26
@yan12125
Copy link
Contributor Author

yan12125 commented Nov 7, 2019

I took another approach that fixes tests on Python 3.8. Anyway, BitbucketPullrequestPoller is already broken for all Python versions as described in #4153.

seankelly
seankelly reviewed Nov 13, 2019
View reviewed changes
.travis.yml
@@ -19,7 +19,7 @@ language: python
# Available Python versions:
# http://about.travis-ci.org/docs/user/ci-environment/#Python-VM-images
python:
- "3.7"
- "3.8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should/can 3.8 be added to .bbtravis.yml?

@yan12125
Copy link
Contributor Author

Should/can 3.8 be added to .bbtravis.yml?

Seems Python 3.8 are not installed on workers yet https://buildbot.buildbot.net/#/builders/2/builds/1132

@tardyp
Copy link
Member

tardyp commented Nov 23, 2019

python 3.8 is now available in the docker image

Chih-Hsuan Yen added 4 commits November 24, 2019 16:47
travis: test on Python 3.8
c4bf0da
Update automat from 0.7.0 to 0.8.0
a89eddb 
Python 3.8 support is available since Automat 0.8.0

See: glyph/automat#118
BitbucketPullrequestPoller: deprecate the non-functional encoding par…
c560c06 
…ameter

The encoding parameter, which is passed to json.loads, has no effects
since Python 3.1 [1]. It also breaks tests in Python 3.8 due to the new
DeprecationWarning.

[1] https://bugs.python.org/issue33461
.bbtravis.yml: try to use Python 3.8
7e7c32e
@yan12125
Copy link
Contributor Author

python 3.8 is now available in the docker image

Thanks! I updated .bbtravis.yml to use Python 3.8, too.

@tardyp tardyp merged commit 2ed9791 into buildbot:master Nov 24, 2019
@yan12125 yan12125 deleted the python38 branch November 24, 2019 16:11
svenstaro pushed a commit to archlinux/svntogit-community that referenced this pull request Jul 22, 2020
upgpkg: buildbot 2.5.1-1
86dc959 
All patches are upstreamed [1][2]

[1] buildbot/buildbot#5037
[2] buildbot/buildbot#5063

git-svn-id: file:///srv/repos/svn-community/svn@533195 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seankelly seankelly seankelly left review comments

@tardyp tardyp tardyp requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yan12125 @tardyp @seankelly