Initial pyjade port to pypugjs #5298
Conversation
Signed-off-by: Brian Dolbec <dolsen@gentoo.org>
Codecov Report
@@ Coverage Diff @@
## master #5298 +/- ##
=======================================
Coverage 89.28% 89.28%
=======================================
Files 335 335
Lines 36526 36526
=======================================
Hits 32612 32612
Misses 3914 3914
Continue to review full report at Codecov.
|
| @@ -131,6 +131,8 @@ This server is configured with the ``www`` configuration key, which specifies a | |||
| * quotes in attributes are not quoted. https://github.com/syrusakbary/pyjade/issues/132 | |||
There was a problem hiding this comment.
we should probably make a quick test and see if this is still the case.
There was a problem hiding this comment.
OK, the new code is identical aside from some minor reformatting. So, no it has not been fixed.
The new code is at lines 145 to 155 of nodes.py
|
Looks good. If we can verify that pyjade/132 is fixed that would actually make a nice improvement. We will need a news fragment as the upgrade will not be seemless as an optional dependency is changing. |
|
I've opened this issue with pypugjs: Hopefully it can be fixed quickly. Have you got an up-to-date link to a file that this fails for? I can take a look at fixing the code to submit a PR. |
|
@dol-sen Could you add a newsfragment? I would then merge the PR. Thanks a lot! |
|
Did tardyp get that bug fixed? We did confirm the bug still exists in pyjade. He was working on a fix. |
|
There were some issues with the investigation uncovered later. See this comment: kakulukia/pypugjs#61 (comment) In any case, this PR does not look to make matters worse, thus can be merged as is. The pypugjs/pyjade bug can be fixed later. |
Ref: buildbot/buildbot#5298 git-svn-id: file:///srv/repos/svn-community/svn@637396 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Signed-off-by: Brian Dolbec dolsen@gentoo.org
This just swaps out the use of pyjade code for a maintained fork of the original pyjade code.
I have a paired down version of this patch which applies to the 2.7.0 release for our Gentoo package repository. I have tested buildbot both with the test suite and running the example buildbot "Hello world" master.cfg