Switch to alembic for database migrations #6224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p12tic
force-pushed
the
alembic
branch
4 times, most recently
from
35a1673
to
4b0b718
Compare
rjarry
requested changes
Sep 8, 2021
rjarry
reviewed
Sep 8, 2021
p12tic
force-pushed
the
alembic
branch
4 times, most recently
from
6a656b2
to
a68f70f
Compare
|
Could you merge #6223 and rebase your alembic branch to eliminate other 2to3 errors ? |
p12tic
force-pushed
the
alembic
branch
2 times, most recently
from
bc00d42
to
d82e64c
Compare
This will be required by a recent version of Alembic
|
@rjarry This PR should be good to go. |
Codecov Report
@@ Coverage Diff @@
## master #6224 +/- ##
==========================================
- Coverage 91.93% 91.89% -0.05%
==========================================
Files 349 331 -18
Lines 37587 37133 -454
==========================================
- Hits 34555 34122 -433
+ Misses 3032 3011 -21
Continue to review full report at Codecov.
|
tardyp
requested changes
Sep 9, 2021
tardyp
approved these changes
Sep 9, 2021
|
Thanks @p12tic 👍 |
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Oct 29, 2021
New dependencies: * python-hvac: buildbot/buildbot#6058 Removed dependencies: * python-sphinxcontrib-blockdiag: buildbot/buildbot#6223 Changed dependencies: * python-sqlalchemy-migrate -> python-alembic: buildbot/buildbot#6224 * python-graphql-core is now a runtime dependency: buildbot/buildbot#5980 Other changes: * Some hacks for Windows service files are upstreamed in buildbot/buildbot#6178 git-svn-id: file:///srv/repos/svn-community/svn@1034915 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Oct 29, 2021
New dependencies: * python-hvac: buildbot/buildbot#6058 Removed dependencies: * python-sphinxcontrib-blockdiag: buildbot/buildbot#6223 Changed dependencies: * python-sqlalchemy-migrate -> python-alembic: buildbot/buildbot#6224 * python-graphql-core is now a runtime dependency: buildbot/buildbot#5980 Other changes: * Some hacks for Windows service files are upstreamed in buildbot/buildbot#6178 git-svn-id: file:///srv/repos/svn-community/svn@1034915 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sqlalchemy-migrate package has been unmaintained for quite some time. This eventually caught up with us - since setuptools 58 one of the dependencies of sqlalchemy-migrate fails to build (see #6222).
This PR replaces the DB migration infrastructure from sqlalchemy-migrate to alembic.
Fixes #6222.
Fixes #5872.
Contributor Checklist:
master/buildbot/newsfragmentsdirectory (and read theREADME.txtin that directory)