New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latent buildslave for OpenStack #666

Merged
merged 11 commits into from Apr 5, 2013

Conversation

Projects
None yet
4 participants
@ghost

ghost commented Mar 18, 2013

The buildslave has limited functionality for interacting with OpenStack's Nova component. Booting and terminating instances works correctly, but no interfacing with the network part.

Add latent buildslave for OpenStack
The buildslave has limited functionality for interacting with
OpenStack's Nova component. Booting and terminating instances
works correctly, but no interfacing with the network part.
@djmitche

View changes

Show outdated Hide outdated master/buildbot/openstackbuildslave.py
@djmitche

View changes

Show outdated Hide outdated master/buildbot/openstackbuildslave.py
@djmitche

View changes

Show outdated Hide outdated master/buildbot/test/unit/test_openstackbuildslave.py
@djmitche

This comment has been minimized.

Show comment
Hide comment
@djmitche

djmitche Mar 18, 2013

Member

Otherwise, please add docs and an entry to the release notes. Thanks!

Member

djmitche commented Mar 18, 2013

Otherwise, please add docs and an entry to the release notes. Thanks!

@djmitche

This comment has been minimized.

Show comment
Hide comment
@djmitche

djmitche Mar 18, 2013

Member

I'm happy. @tomprince is going to have a look shortly.

Member

djmitche commented Mar 18, 2013

I'm happy. @tomprince is going to have a look shortly.

@tomprince

View changes

Show outdated Hide outdated master/buildbot/buildslave/openstack.py
@tomprince

This comment has been minimized.

Show comment
Hide comment
@tomprince

tomprince Mar 18, 2013

Member

We use camelCase rather than underscore (following twisted). (We do use underscores occasionaly, in naming test methods, as a phrase seperator.

Member

tomprince commented Mar 18, 2013

We use camelCase rather than underscore (following twisted). (We do use underscores occasionaly, in naming test methods, as a phrase seperator.

@tomprince

View changes

Show outdated Hide outdated master/buildbot/test/unit/test_buildslave_openstack.py
@tomprince

View changes

Show outdated Hide outdated master/buildbot/test/unit/test_buildslave_openstack.py
@tomprince

View changes

Show outdated Hide outdated master/buildbot/test/unit/test_buildslave_openstack.py
@tomprince

View changes

Show outdated Hide outdated master/docs/manual/cfg-buildslaves.rst
@tomprince

This comment has been minimized.

Show comment
Hide comment
@tomprince

tomprince Mar 19, 2013

Member

It would be nice if the fakes tracked the calls with side-effects, and then made assertions about them.

Member

tomprince commented Mar 19, 2013

It would be nice if the fakes tracked the calls with side-effects, and then made assertions about them.

seankelly added some commits Mar 19, 2013

Drop creating and using ConcreteBuildSlave
Not using an abstract slave, so do not need a concrete version. Some of
the lines are a bit long; this will be fixed later.
Use keyword args in test
Due to the number of required arguments, use keywords for them to be
clearer about what's being specified. Also changed the flavor to be an
integer because the docs say to pass the flavor ID, not name.
Update docs
Use keyword arguments in the examples and list the keyword arguments
with a brief description on each.
@djmitche

This comment has been minimized.

Show comment
Hide comment
@djmitche

djmitche Mar 21, 2013

Member

@tomprince, please have a look at the updates here when you're back on dry land.

Member

djmitche commented Mar 21, 2013

@tomprince, please have a look at the updates here when you're back on dry land.

Include the image UUID in the log
The instance name was included in the log message, but this is identical
to the slave name. Instead, include the image UUID as this could
actually help in debugging.
@djmitche

This comment has been minimized.

Show comment
Hide comment
@djmitche
Member

djmitche commented Apr 1, 2013

@tomprince - ping?

@djmitche

This comment has been minimized.

Show comment
Hide comment
@djmitche

djmitche Apr 5, 2013

Member

I'm going to get this merged. @tomprince, please have a look when you get a chance and we can fix any problems post-merge.

Member

djmitche commented Apr 5, 2013

I'm going to get this merged. @tomprince, please have a look when you get a chance and we can fix any problems post-merge.

@djmitche djmitche merged commit 6cdebac into buildbot:master Apr 5, 2013

# started.
return defer.succeed(None)
instance = self.instance
self.instance = None

This comment has been minimized.

@jaredgrubb

jaredgrubb Apr 5, 2013

Member

stop_instance can be called from the reactor right? If so, I dont think unseating self.instance is right, as that could make the worker thread crash, which references self.instance in a few places.

@jaredgrubb

jaredgrubb Apr 5, 2013

Member

stop_instance can be called from the reactor right? If so, I dont think unseating self.instance is right, as that could make the worker thread crash, which references self.instance in a few places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment