-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable bzlmod #27
base: master
Are you sure you want to change the base?
Enable bzlmod #27
Conversation
bazel_dep(name = "buildbuddy_toolchain", repo_name = "buildbuddy") | ||
local_path_override( | ||
module_name = "buildbuddy_toolchain", | ||
path = "../../", | ||
) | ||
|
||
buildbuddy = use_extension("@buildbuddy//:extensions.bzl", "buildbuddy") | ||
use_repo(buildbuddy, "buildbuddy_toolchain") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The naming here could be quite confusing to new users. Any suggestion? 🤔
We have:
- The module name, which is
buildbuddy_toolchain
but is then renamed tobuildbuddy
-> this is essentially our git repo. - The extension name, which is
buildbuddy
. - The repository that was created by the extension, which is named
buildbuddy_toolchain
-> this contains the actual platform and toolchain definitions.
You may consider to add some parameters for configuration. // Load rules from BCR buildbuddy = use_extension("@buildbuddy//:extensions.bzl", "buildbuddy") // Do wee need to call register_toolchains??? I don't think the naming is too much different from what's out there. Is it perfect, no, but given I would be open to test this rules once merged because I am converting my main repo to bzlmod and this is the last rule on my list. |
Hello @sluongng, thank you for working on this |
Enable bzlmod for BuildBuddy toolchain