Add checkstyle check and fix script for go deps #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
changed the title
bduffany
force-pushed
the
tidyup
branch
9 times, most recently
from
139d08e
to
82fa145
Compare
bduffany
changed the title
bduffany
requested review from
siggisim,
luluz66,
tempoz,
tylerwilliams and
vadimberezniker
bduffany
force-pushed
the
tidyup
branch
2 times, most recently
from
738a7b8
to
36b6592
Compare
bduffany
force-pushed
the
tidyup
branch
3 times, most recently
from
da8fad7
to
a43fad3
Compare
.github/workflows/checkstyle.yaml
Outdated
| - name: Setup go | ||
| uses: actions/setup-go@v2 | ||
| with: | ||
| go-version: "1.17.2" |
There was a problem hiding this comment.
do you want to leave a comment in WORKSPACE that points to this file and mentions these versions should be kept in sync?
| @@ -0,0 +1,79 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
can you add an option to ./buildfix.sh that does this so we continue to have one script that will "ready" your build for review?
There was a problem hiding this comment.
Done, can now use ./buildfix.sh --go_deps flag to additionally invoke this script as part of ./buildfix.sh
Also added an --all flag that is the same as --gazelle --go_deps.
|
FYI, verified that this works on Mac. |
tempoz
reviewed
Jan 28, 2022
| @@ -5,26 +5,27 @@ go 1.17 | |||
| replace ( | |||
| github.com/firecracker-microvm/firecracker-go-sdk => github.com/tylerwilliams/firecracker-go-sdk v0.22.1 | |||
| github.com/go-redsync/redsync/v4 v4.4.1 => github.com/bduffany/redsync/v4 v4.4.1-minimal | |||
| github.com/lni/dragonboat/v3 => github.com/tylerwilliams/dragonboat/v3 v3.3.4-rc2 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to enforce the following:
go mod tidy -ewould produce no diffs togo.modorgo.sumgo.modhas exactly 2require()blocks, one for direct imports and one for indirect imports. See cmd/go: lazy modules: separate section for indirect imports golang/go#45965deps.bzlvia Gazelle would produce no diffsProvides a script to automatically fix most errors detected, or provide instructions on how to manually fix (
tools/fix_go_deps.sh)Note: the
-eflag togo mod tidylets us avoid the need to add the generated protos to the repo before runninggo mod tidy. This flag is not supported in Go 1.15 (the version currently used in GH actions), so this PR also adds a step to upgrade the Go version to v1.17.Example failing run (before running
tools/fix_go_deps.shin this PR): https://github.com/buildbuddy-io/buildbuddy/runs/4960976363?check_suite_focus=true -- the diff is huge here becausego.modis particularly whacky these days, but the diff should be much smaller in the future.Version bump: Patch