Add more invocation suggestions (round 2) #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
commented
May 18, 2022
| ({ model }) => { | ||
| if (!capabilities.config.expandedSuggestionsEnabled) return null; | ||
|
|
||
| if (model.optionsMap.get("incompatible_strict_action_env") !== undefined) return null; |
There was a problem hiding this comment.
@siggisim I wasn't sure whether we want to show this across the board, or only if remote cache is enabled. wdyt?
There was a problem hiding this comment.
I don't think we should suggest it until we can mark suggestions as "I don't want to do this". Most iOS projects shouldn't actually set this, and should instead filter PATH in tools/bazel, since --incompatible_strict_action_env adds /usr/local/bin, which picks up Homebrew on Intel Macs.
There was a problem hiding this comment.
Thanks for pointing this out -- removed from this PR.
siggisim
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggest using-- removed this one, since Brentley pointed out it's not desirable for iOS builds, and there may be other cases I'm not aware of.--incompatible_strict_action_envif not setCOMMIT_SHAandREPO_URLmetadata if this is a CI test and those pieces of metadata are missingVersion bump: Patch
Related issues: https://github.com/buildbuddy-io/buildbuddy-internal/issues/1357