Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos: make --config=remote work again #5680

Merged
merged 1 commit into from
Jan 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,9 @@ common:windows --cxxopt=/std:c++17
# This is currently not avoidable with the current way the local cc toolchain is configured
# as well as how linkopts are propagated through the dependency graph between libraries.
# This flag is a workaround to silence the linker warnings.
common:macos --linkopt="-Wl,-no_warn_duplicate_libraries"
common:macos --host_linkopt="-Wl,-no_warn_duplicate_libraries"
# common:macos --linkopt="-Wl,-no_warn_duplicate_libraries"
# common:macos --host_linkopt="-Wl,-no_warn_duplicate_libraries"
common:macos --platform_mappings=platform_mapping

# Ensure that we don't use the apple_support cc_toolchain
common:macos --repo_env=BAZEL_NO_APPLE_CPP_TOOLCHAIN=1
Expand Down
4 changes: 4 additions & 0 deletions platform_mapping
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
platforms:
@local_config_platform//:host
--linkopt="-Wl,-no_warn_duplicate_libraries"
--host_linkopt="-Wl,-no_warn_duplicate_libraries"