Move AuthorizeGroupAccess to authutil #5905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimberezniker
approved these changes
Feb 13, 2024
bduffany
force-pushed
the
cleanup-auth-group-id
branch
from
97ebcb0
to
56dcac4
Compare
bduffany
force-pushed
the
perms-rm-group-access
branch
from
42c07e8
to
f599569
Compare
bduffany
force-pushed
the
perms-rm-group-access
branch
from
f599569
to
7ee1d06
Compare
bduffany
force-pushed
the
perms-rm-group-access
branch
from
7ee1d06
to
619a86d
Compare
bduffany
requested review from
jdhollen
and removed request for
tempoz and
luluz66
bduffany
force-pushed
the
perms-rm-group-access
branch
from
619a86d
to
d52b8ae
Compare
jdhollen
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These 2 funcs don't have anything to do with our unix-like perms bits, so move them to authutil. (See also the PR description of #5899 for more context.)
Also, update
AuthorizeGroupAccessto useGetGroupMemberships()instead of the deprecatedGetAllowedGroups().Related issues: N/A