Ignore invalid flags in the ci_runner script #6080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maggie-lou and the rest of your teammates on |
tylerwilliams
approved these changes
Mar 6, 2024
bduffany
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to add flags to this script in the future.
Right now, if you pass an undefined flag to this script, the script will immediately fail when
flag.Parseencounters the unexpected flag. This will make it challenging to ever iterate on this script and add new flags, especially because customers with self-hosted executors may rarely update their executors to pull in new changes to this script. The workflow service / our schedulers don't know what version of this script will be on an executor, so it won't be able to tell whether it's safe to send a new flag.