Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev QA script #6092

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Fix dev QA script #6092

merged 3 commits into from
Mar 11, 2024

Conversation

maggie-lou
Copy link
Contributor

@maggie-lou maggie-lou commented Mar 7, 2024

  • Disable bzlmod on builds (and remove bazel repo build because it's been fully migrated to bzlmod, and we haven't done enough testing to guarantee our toolchain work well with bzlmod)
  • Fail script if a QA build fails
  • Add API key to builds
  • Update to the latest buildbuddy toolchain

Related issues: Fixes https://github.com/buildbuddy-io/buildbuddy-internal/issues/3167

@maggie-lou
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maggie-lou and the rest of your teammates on Graphite Graphite

@maggie-lou maggie-lou force-pushed the fix_dev_qa branch 20 times, most recently from 460f9f9 to d19f17a Compare March 8, 2024 16:57
@maggie-lou maggie-lou changed the title [WIP] Fix dev QA script Fix dev QA script Mar 8, 2024
},
{
"name": "bazel",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: instead of removing bazel we could also pin at a known good commit and bazel version. I think in general we probably want to pin all of these to a known good commit (plus a bazel version if a .bazelversion is missing from the repo), so that if these repos break then we don't have to block the release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done - pinned all the commit shas to current HEAD. For the bazel repo, pinned to the parent commit before they cleared their WORKSPACE file. Also pinned bazel version to 7.0.2

Was going back and forth on whether we should pin the bazel version, because we might want to know if builds are breaking on a later bazel version. But I think pinning it will make things more stable, and we can find that out other ways

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually having trouble getting bazel repo to build on an older commit. I want to make sure these fixes get in before the next release, so just going to remove bazel for now. We'll still have a go, c++, and python test build

Copy link
Member

@bduffany bduffany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (we can maybe pin these to known good commits another time, since that seems like it might be slightly tricky when using the github checkout action)

@maggie-lou maggie-lou force-pushed the fix_dev_qa branch 2 times, most recently from af799b7 to 6dc8102 Compare March 8, 2024 19:36
@maggie-lou maggie-lou force-pushed the fix_dev_qa branch 6 times, most recently from 817688c to 5cb4da2 Compare March 11, 2024 18:55
@maggie-lou maggie-lou enabled auto-merge (squash) March 11, 2024 19:09
@maggie-lou maggie-lou merged commit a28e585 into master Mar 11, 2024
12 of 17 checks passed
@maggie-lou maggie-lou deleted the fix_dev_qa branch March 11, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants