Fix executable diagnostics #6126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
force-pushed
the
vmexec-fix-logging
branch
3 times, most recently
from
cc24f15
to
1bed83f
Compare
jdhollen
reviewed
Mar 12, 2024
jdhollen
approved these changes
Mar 12, 2024
bduffany
force-pushed
the
vmexec-fix-logging
branch
6 times, most recently
from
cdb118c
to
a68f29a
Compare
bduffany
force-pushed
the
vmexec-fix-logging
branch
from
a68f29a
to
f5d2fdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also log the first 1K bytes of the executable (I realized that if there is corruption, just knowing the digest of the corrupted contents will not be super helpful)
Related issues: N/A