Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix approvals on changes when the user has no draft comments #6173

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

jdhollen
Copy link
Member

For those of us who just smash approve

Related issues: N/A

@jdhollen jdhollen marked this pull request as ready for review March 15, 2024 22:25
Copy link
Member

@tylerwilliams tylerwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

proto/github.proto Outdated Show resolved Hide resolved
Co-authored-by: Tyler Williams <williams.tyler@gmail.com>
@jdhollen jdhollen merged commit ce9cc1f into master Mar 15, 2024
18 of 19 checks passed
@jdhollen jdhollen deleted the jh/2024-03-15_approve-fix branch March 15, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants