Fix nil pointer ref in vbd #6179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maggie-lou and the rest of your teammates on |
tylerwilliams
approved these changes
Mar 18, 2024
maggie-lou
changed the title
bduffany
reviewed
Mar 18, 2024
enterprise/server/remote_execution/containers/firecracker/firecracker.go
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error: https://buildbuddy-corp.slack.com/files/USLACKBOT/F06QSAARCAU/new_error_in_flame-build_executor_executor-54df5bd945-dkck9
We unmount vbd in the background, which sets f.server=nil when it's complete. We also may return early from the Unmount call if the context is cancelled, and we don't wait for the background unmount process to complete. If we don't set the vbd=nil, when we're cleaning up the VM we might try to unmount again, which will cause a nil pointer ref