Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SS] Align disks to page size #6184

Merged
merged 2 commits into from
Mar 19, 2024
Merged

[SS] Align disks to page size #6184

merged 2 commits into from
Mar 19, 2024

Conversation

maggie-lou
Copy link
Contributor

We're seeing some suspicious warnings like "Disk size 15319603456 is not a multiple of sector size 512; the remainder will not be visible to the guest." Align the disks to ensure there's no unpredictable behavior around this.

@maggie-lou
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maggie-lou and the rest of your teammates on Graphite Graphite

Copy link
Member

@bduffany bduffany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: in the basic snapshot + resume test wdyt about adding an assertion that the VM log doesn't contain "not a multiple of sector size"? the VM log should be present in the CommandResult returned by Exec

@maggie-lou maggie-lou merged commit 5cefd30 into master Mar 19, 2024
15 of 18 checks passed
@maggie-lou maggie-lou deleted the align_disk branch March 19, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants