cli/fix: support bzlmod #6191
cli/fix: support bzlmod #6191
Conversation
sluongng
force-pushed
the
sluongng/cli-support-bzlmod
branch
2 times, most recently
from
ca409fc
to
779ca91
Compare
|
There is a dependency between this made it's not possible to use |
|
I want to trickle I think we could make do with an assumption with |
sluongng
force-pushed
the
sluongng/cli-support-bzlmod
branch
from
30b6566
to
dbc8a26
Compare
cli/bazelisk/bazelisk.go
Outdated
| // Prevent Bazelisk `log.Printf` call to write directly to stderr | ||
| oldWriter := log.Writer() | ||
| log.SetOutput(stderr) | ||
| defer log.SetOutput(oldWriter) | ||
|
|
There was a problem hiding this comment.
it seems OK to me to put this logic in Run() since to me the expected behavior of RunOpts would be that all stderr/stdout from bazelisk, including go logs, goes to the stdout/stderr writers passed in. wdyt?
There was a problem hiding this comment.
hmm I tried fitting it in if RunOpts.stderr is set 🤔
Ensure that bzlmod is correctly detected. In case bzlmod is used, we need to query for the location of @@gazelle~override~go_deps~bazel_gazelle_go_repository_config//:WORKSPACE so that we could feed it to Gazelle to generate BUILD files with correct import.
sluongng
force-pushed
the
sluongng/cli-support-bzlmod
branch
from
01127c3
to
6826477
Compare
sluongng
force-pushed
the
sluongng/cli-support-bzlmod
branch
from
6826477
to
f501fe4
Compare
Ensure that bzlmod is correctly detected.
In case bzlmod is used, we need to query for the location of
so that we could feed it to Gazelle to generate BUILD files with correct
import.