Upgrade firecracker to v1.7.0 #6208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
force-pushed
the
firecracker-v1.7.0
branch
from
0a973e1
to
5a81db2
Compare
bduffany
force-pushed
the
firecracker-v1.7.0
branch
from
5a81db2
to
3b744a9
Compare
maggie-lou
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deps.bzlwhen upgrading and not the genrule targets as well. (Some tweaking here was also necessary because they introduced a new top-levelrelease-*directory in the tar archive which contains the firecracker/jailer binaries, rather than the binaries just being in the top-level of the archive)UffdPrivileged(not supported by upstream firecracker, and seems to not be needed anymore. The tests pass, at least)firecracker_versionis part of the VmConfiguration for now, which is part of the snapshot cache key.The baremetal tests aren't exercising the new version yet because they use the firecracker binary from the currently deployed executor image, but I ran the baremetal tests locally and they are passing.
Related issues: N/A