Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make more firecracker errors retryable #6233

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Make more firecracker errors retryable #6233

merged 1 commit into from
Mar 27, 2024

Conversation

bduffany
Copy link
Member

Related issues: N/A

jdhollen
jdhollen approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@jdhollen jdhollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can both recognize that you are using UnavailableError properly and also claim that it is the worst-named status in grpc

@bduffany bduffany merged commit 4dd9a86 into master Mar 27, 2024
12 of 18 checks passed
@bduffany bduffany deleted the firecracker-unavailable branch March 27, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhollen jdhollen jdhollen approved these changes

@tylerwilliams tylerwilliams Awaiting requested review from tylerwilliams

@maggie-lou maggie-lou Awaiting requested review from maggie-lou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bduffany @jdhollen