ci_main: fix cred helper handle 'store' #6263
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous change, we managed to detect when the credential helper
was invoked by
git
with theget
operation and provide a specialespcape hatch for it.
However,
get
is not the only operation thatgit
will call us with.The other operations include
store
anderase
in the currentgit-credentials spec.
Adjust the credential helper detection when parsing flags to make sure
we don't run into infinite loop with
store
anderase
operations(or future new operations).