Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci_main: fix cred helper handle 'store' #6263

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

sluongng
Copy link
Contributor

@sluongng sluongng commented Mar 29, 2024

In a previous change, we managed to detect when the credential helper
was invoked by git with the get operation and provide a special
espcape hatch for it.

However, get is not the only operation that git will call us with.
The other operations include store and erase in the current
git-credentials spec.

Adjust the credential helper detection when parsing flags to make sure
we don't run into infinite loop with store and erase operations
(or future new operations).

@sluongng sluongng changed the title fix store case ci_main: fix cred helper handle 'store' Mar 29, 2024
@sluongng sluongng marked this pull request as ready for review March 29, 2024 10:06
@sluongng sluongng force-pushed the sluongng/fix-cred-helper-store branch from 7081156 to c35da89 Compare March 29, 2024 16:31
@sluongng sluongng requested a review from bduffany March 29, 2024 17:02
@sluongng sluongng force-pushed the sluongng/fix-cred-helper-store branch from c35da89 to 179021e Compare April 1, 2024 09:15
@sluongng sluongng merged commit 786f1dd into master Apr 2, 2024
15 of 16 checks passed
@sluongng sluongng deleted the sluongng/fix-cred-helper-store branch April 2, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants