nogo: enable SA4010 #6264
Merged
nogo: enable SA4010 #6264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluongng
commented
Mar 29, 2024
| if _, ok := gotMap[h]; !ok { | ||
| stillMissing = append(stillMissing, h) | ||
| } | ||
| } |
There was a problem hiding this comment.
The last time this was used is in a Debug log.
The log was removed in f7feb5c according to
git log -p -L:\ GetMulti\(:enterprise/server/backends/distributed/distributed.go -W
this result of append is never used, except maybe in other appends
sluongng
force-pushed
the
sluongng/SA4010
branch
from
3f49c6d
to
2d04d3e
Compare
vadimberezniker
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this result of append is never used, except maybe in other appends