Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linked github repos to code editor empty state #6271

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

siggisim
Copy link
Member

Related issues: N/A

@siggisim siggisim requested a review from bduffany March 29, 2024 15:23
@@ -4,13 +4,15 @@ import { invocation } from "../../../proto/invocation_ts_proto";
import format from "../../../app/format/format";

interface State {
repoStats: invocation.InvocationStat[];
reposWithStats: string[];
linkedRepos: string[];
loading: boolean;
}

export default class CodeEmptyStateComponent extends React.Component {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export default class CodeEmptyStateComponent extends React.Component {
export default class CodeEmptyStateComponent extends React.Component<{}, State> {

(this will probably surface some type errors 😛 )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed

@siggisim siggisim merged commit ffc32ec into master Mar 29, 2024
11 of 16 checks passed
@siggisim siggisim deleted the siggi-dev-branch-20240329-082312 branch March 29, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants