Run RBE tests on linux-arm64 #6289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
force-pushed
the
rbetest-linux-arm64
branch
from
3642087
to
1f53147
Compare
bduffany
changed the title
bduffany
force-pushed
the
rbetest-linux-arm64
branch
from
1f53147
to
f86d179
Compare
bduffany
force-pushed
the
rbetest-linux-arm64
branch
2 times, most recently
from
ab62a1e
to
d7ffd53
Compare
bduffany
force-pushed
the
rbetest-linux-arm64
branch
9 times, most recently
from
56a2918
to
ac8b331
Compare
bduffany
changed the title
bduffany
force-pushed
the
rbetest-linux-arm64
branch
2 times, most recently
from
755416d
to
cc443ac
Compare
bduffany
force-pushed
the
rbetest-linux-arm64
branch
6 times, most recently
from
2b1e191
to
b663332
Compare
bduffany
force-pushed
the
rbetest-linux-arm64
branch
2 times, most recently
from
38f538f
to
7721959
Compare
tylerwilliams
approved these changes
Apr 2, 2024
bduffany
force-pushed
the
rbetest-linux-arm64
branch
5 times, most recently
from
5d35f47
to
0ce5055
Compare
iain-macdonald
approved these changes
Apr 2, 2024
sluongng
approved these changes
Apr 3, 2024
Comment on lines
+20
to
+33
| # GitHub's arm64 runners do not have the same pre-installed software as | ||
| # the amd64 runners so we have to install a few things here. | ||
|
|
||
| - name: Install bazelisk | ||
| run: | | ||
| curl -L --output /tmp/bazelisk https://github.com/bazelbuild/bazelisk/releases/download/v1.17.0/bazelisk-linux-arm64 | ||
| chmod +x /tmp/bazelisk | ||
| sudo mv /tmp/bazelisk /usr/bin/bazelisk | ||
| sudo ln -s /usr/bin/bazelisk /usr/bin/bazel | ||
|
|
||
| - name: Install apt packages | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y gcc g++ podman |
There was a problem hiding this comment.
Could we run these in an ARM64 container? 🤔
https://docs.github.com/en/actions/using-jobs/running-jobs-in-a-container
It could simplify this setup by quite a bit.
There was a problem hiding this comment.
Container jobs aren't supported in the arm runners beta yet - idk if it's mentioned in the public docs but they mentioned that in their email.
| [engine] | ||
| cgroup_manager = "cgroupfs" | ||
| ' | ||
| mkdir -p ~/.local |
There was a problem hiding this comment.
dumb question: why is ~/.local needed to be created manually here?
There was a problem hiding this comment.
Don't remember why I added this but it works without it - removed.
| @@ -380,9 +385,13 @@ func TestForceRoot(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestUser(t *testing.T) { | |||
| if runtime.GOARCH == "arm64" { | |||
| // TODO: build podman ourselves, and remove this | |||
| t.Skipf("--passwd arg is not yet supported by podman version available on GitHub actions runner") | |||
There was a problem hiding this comment.
Nit: specify the expected vs actual version number so we can flip this in the future when newer versions become available.
bduffany
force-pushed
the
rbetest-linux-arm64
branch
from
0ce5055
to
d952edd
Compare
bduffany
force-pushed
the
rbetest-linux-arm64
branch
from
d952edd
to
e1e1bd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a GitHub workflow that runs applicable RBE tests on linux-arm64 runners.
Related issues: N/A