Add a button to invalidate all workflows for a repo #6308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maggie-lou
force-pushed
the
invalidate_button
branch
from
86ccdc0
to
25400aa
Compare
maggie-lou
force-pushed
the
invalidate_button
branch
2 times, most recently
from
67c62ee
to
c3deae1
Compare
maggie-lou
force-pushed
the
invalidate_button
branch
2 times, most recently
from
487cfcc
to
0ec6641
Compare
maggie-lou
force-pushed
the
clean_clean
branch
2 times, most recently
from
1e78db5
to
f4ecaa5
Compare
maggie-lou
changed the title
maggie-lou
force-pushed
the
clean_clean
branch
2 times, most recently
from
77bf556
to
c5adc6e
Compare
maggie-lou
force-pushed
the
invalidate_button
branch
from
2e23944
to
c8c731d
Compare
bduffany
reviewed
Apr 9, 2024
| // In the latter case, we want to be careful to not fallback to an older, | ||
| // invalid snapshot. So here we generate a new version ID to guarantee | ||
| // we start from a clean snapshot. | ||
| return l.env.GetSnapshotService().InvalidateSnapshot(ctx, key) |
There was a problem hiding this comment.
what's the difference between calling InvalidateSnapshot here and returning a new random string directly?
There was a problem hiding this comment.
InvalidateSnapshot saves the version metadata in the cache. We want to make sure it's set, or every VM will generate a new version ID.
Ex. Let's say the version metadata expires from the cache.
T0: A VM starts up. There's no version metadata in the cache, so it generates a new version. It completes and saves a snapshot (saving a snapshot does not update the version metadata)
T1: Another VM starts up. If we hadn't saved the version metadata at T0, this will also generate a new version
maggie-lou
force-pushed
the
invalidate_button
branch
5 times, most recently
from
a8dd9cb
to
c8d0eaa
Compare
bduffany
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of the "rerun from clean runner" button to only invalidate the relevant workflow snapshot. Previously, the button would invalidate all workflows for that repo.
Add a new button to the workflows page to invalidate all workflows for a repo. We may need this if we make a breaking change that requires a universal snapshot upgrade, like a firecracker version increase, for example.
Also remove usages of ExecuteWorkflowRequest.Clean in preparation of deprecating that field. It's strange behavior that we could invalidate snapshots of unrelated workflows when invoking ExecuteWorkflow. We should use the new targeted API for this case.
Related issues: N/A