Disable Firecracker and soci-snapshotter on arm64 for now #6315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll need arm64 builds of soci-snapshotter as well as arm64 builds of vmlinux before we can enable these. Would also be good to have CI tests for these to avoid breakage. Since this seems like significant work, just disable these for now.
bduffany
force-pushed
the
fc-arm64-disable
branch
from
5a079cb
to
9712c56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll need arm64 builds of soci-snapshotter as well as vmlinux and firecracker/jailer before we can enable these. Would also be good to have CI tests for these to avoid breakage. Since this seems like significant work, disable these for now and avoid building / shipping them as part of the go binary / docker image.
Related issues: N/A