Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a button to the action details page to invalidate a recycled runner snapshot #6333

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

maggie-lou
Copy link
Contributor

@maggie-lou maggie-lou commented Apr 9, 2024

Screenshot 2024-04-09 at 2 37 11 PM
Screenshot 2024-04-09 at 2 37 18 PM
Screenshot 2024-04-09 at 2 37 24 PM

Related issues: N/A

@maggie-lou maggie-lou force-pushed the rbe_invalidate_button branch 7 times, most recently from 039886d to 71a3980 Compare April 9, 2024 19:36
@maggie-lou maggie-lou changed the title WIP Add a button to the action details page to invalidate a recycled runner snapshot Apr 9, 2024
@maggie-lou maggie-lou force-pushed the invalidate_button branch 5 times, most recently from a8dd9cb to c8d0eaa Compare April 12, 2024 17:47
Base automatically changed from invalidate_button to master April 18, 2024 16:35
@maggie-lou maggie-lou force-pushed the rbe_invalidate_button branch 3 times, most recently from f7243fa to f45ea05 Compare April 18, 2024 20:37
@maggie-lou maggie-lou marked this pull request as ready for review April 18, 2024 20:50
@jdhollen
Copy link
Member

first of all, hell yeah

second, what do you think of just making this a button right next to the "saved from" and/or "resumed from" headers in the execution metadata? it's kind of far away from the thing that it affects right now, and we're not short on whitespace in the metadata section :P

@maggie-lou
Copy link
Contributor Author

first of all, hell yeah

second, what do you think of just making this a button right next to the "saved from" and/or "resumed from" headers in the execution metadata? it's kind of far away from the thing that it affects right now, and we're not short on whitespace in the metadata section :P

Sounds good to me. Are you thinking another line item in the vertical list? Or a button offset to the right, like it is in this PR, but closer to the relevant data?

Copy link
Member

@bduffany bduffany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM as a first iteration - I agree w/ Jim's comment about possibly putting it closer to the snapshot info. Maybe something like this hacked up HTML could work?

image

image

or moving the 3-dot to the same row also seems good if you want to just keep what's already implemented in this PR

app/invocation/invocation_action_card.tsx Outdated Show resolved Hide resolved
app/invocation/invocation_action_card.tsx Outdated Show resolved Hide resolved
@maggie-lou maggie-lou force-pushed the rbe_invalidate_button branch 3 times, most recently from aa98260 to e64d80e Compare April 29, 2024 18:43
@maggie-lou maggie-lou force-pushed the rbe_invalidate_button branch 2 times, most recently from cb093b9 to fa4917c Compare April 29, 2024 18:54
@maggie-lou maggie-lou merged commit 8b6a208 into master Apr 29, 2024
19 checks passed
@maggie-lou maggie-lou deleted the rbe_invalidate_button branch April 29, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants