Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use podman-static version at HEAD in integration tests #6337

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Use podman-static version at HEAD in integration tests #6337

merged 4 commits into from
Apr 12, 2024

Conversation

bduffany
Copy link
Member

@bduffany bduffany commented Apr 9, 2024 •
edited

  • Add a rule that repackages podman-static into a format where we can consume it easily from both integration tests and in the executor image.
  • Update integration tests to install podman-static from the archive instead of using a pre-installed version in the container image

Related issues: N/A

@bduffany bduffany force-pushed the podman-static-bazelify branch 5 times, most recently from 6fcea81 to d592d96 Compare April 9, 2024 19:34
@bduffany bduffany marked this pull request as ready for review April 9, 2024 19:42
@bduffany bduffany force-pushed the podman-static-bazelify branch 4 times, most recently from eb2feb9 to 26c89ab Compare April 9, 2024 19:47
iain-macdonald
iain-macdonald reviewed Apr 10, 2024
View reviewed changes
deps.bzl Outdated Show resolved Hide resolved
sluongng
sluongng approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@sluongng sluongng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only small nits from me.

Good improvement overall. 🙇

enterprise/server/remote_execution/containers/podman/BUILD Show resolved Hide resolved
enterprise/server/remote_execution/containers/podman/BUILD Show resolved Hide resolved
enterprise/server/remote_execution/containers/podman/BUILD Outdated Show resolved Hide resolved
platforms/podman/version.bzl Outdated Show resolved Hide resolved
sluongng
sluongng reviewed Apr 11, 2024
View reviewed changes
deps.bzl Show resolved Hide resolved
@bduffany bduffany merged commit 311f4e0 into master Apr 12, 2024
18 of 19 checks passed
@bduffany bduffany deleted the podman-static-bazelify branch April 12, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iain-macdonald iain-macdonald iain-macdonald approved these changes

@sluongng sluongng sluongng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bduffany @iain-macdonald @sluongng