Move VMMetadata proto to a more fitting home #6341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maggie-lou
force-pushed
the
vm_metadata_proto
branch
2 times, most recently
from
0ca4ee0
to
ab9bdb1
Compare
maggie-lou
force-pushed
the
vm_metadata_proto
branch
from
ab9bdb1
to
d8cd7c6
Compare
maggie-lou
changed the title
maggie-lou
force-pushed
the
vm_metadata_proto
branch
from
8ccbd4b
to
5a6a5a7
Compare
maggie-lou
force-pushed
the
vm_metadata_proto
branch
from
5a6a5a7
to
5c1109b
Compare
bduffany
approved these changes
Apr 11, 2024
| return this.getDeprecatedFirecrackerVMMetadata(); | ||
| } | ||
| for (const metadata of auxiliaryMetadata) { | ||
| if (metadata.typeUrl.includes("firecracker.VMMetadata")) { |
There was a problem hiding this comment.
nit: can we do an equality check on the typeUrl instead of .includes() ? or does the URL include some contents we aren't expecting?
There was a problem hiding this comment.
Changed. I thought the includes might be slightly less brittle, but don't feel strongly
This was referenced Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VMMetadata proto feels a little too firecracker-specific to live in remote_execution.proto. I've hit some problems with import cycles (firecracker.proto needs to import remote_execution.proto for generic RBE concepts like
files, but now there is an implicit import loop because remote_execution.proto contains the definition for this firecracker-specific field).This PR sets VMMetadata in the more generic
repeated google.protobuf.Any auxiliary_metadatafield ofExecutedActionMetadata. That allows us to move the proto definition into firecracker.protoRelated issues: Based on feedback/challenges from #6303