split out data model for code review into immutable objects #6342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdhollen
force-pushed
the
jh/2024-04-04_single-file
branch
from
0acc02e
to
7a03a1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a little Light Refactoring™
Review, Thread, and Comment are now immutable objects, modulo a few things that are less urgent to do this for--i've left TODOs for those fields.
This will make it much easier to build a coherent model where the user can move between different pages (viewing a single file, replying, viewing all files, ...) without worrying too much about maintaining state properly. Shoulda done this sooner.
Related issues: N/A