Update DB schema for workflows non-root migration #6351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
force-pushed
the
wf-nonroot-default
branch
from
d27b9d9
to
f46dce2
Compare
maggie-lou
reviewed
Apr 11, 2024
server/tables/tables.go
Outdated
| // DefaultNonRootRunner decides whether workflow and remote bazel runs | ||
| // within this repository should run as a non-root user by default. | ||
| // TODO(http://go/b/3286): Remove this field after completing migration. | ||
| DefaultNonRootRunner bool `gorm:"not null;default:false"` |
There was a problem hiding this comment.
Can you change to default:0
Bools are stored as tiny ints. There's a bug in the gorm library where it thinks a migration is occurring where the default value is changing from false -> 0
There was a problem hiding this comment.
I asked @tempoz for help understanding this - my understanding of the situation is
- We used to store bools as
tinyintin mysql (6b2e537) - postgres does not support
tinyint, so we had to change those to bool - For those existing fields we need to keep them as 0/1 which is compatible with both bool and tinyint, so mysql does not try to migrate from
tinyinttobool - For new bool fields, it's fine to use false/true
I'm gonna make this numeric anyway just for consistency though. At some point it might be worth either migrating the MySQL columns to be proper bools (if it's inexpensive) or adding a test that ensures we consistently use 0/1 for bool defaults
maggie-lou
reviewed
Apr 11, 2024
maggie-lou
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: https://github.com/buildbuddy-io/buildbuddy-internal/issues/3286