New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small tweaks to firecracker cleanup script #6352

Merged

bduffany merged 1 commit into master from fc-clean-tweaks

Apr 11, 2024

Member

bduffany commented Apr 11, 2024 •

edited

Kill firecracker processes first (before removing network resources that may be in use)
Kill with SIGKILL so firecracker exits immediately
Don't fail if there are no firecracker processes
Don't fail if there are no net namespaces to clean up
Get rid of iptables clean up (pretty sure this is not needed - our networking cleanup in Go code doesn't do this)

Related issues: N/A


          Small tweaks to firecracker clean script

15fbbd6

bduffany requested a review from maggie-lou

April 11, 2024 14:11

maggie-lou approved these changes

View reviewed changes

bduffany merged commit 90f6ee1 into master

18 checks passed

bduffany deleted the fc-clean-tweaks branch

April 11, 2024 16:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment