Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable debug logs in disconnectedContext.Deadline() #6353

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Conversation

bduffany
Copy link
Member

@bduffany bduffany commented Apr 11, 2024

These debug logs are turning out too noisy and making the logs less usable.

Related issues: N/A

@maggie-lou
Copy link
Contributor

This is still really spammy if you're using ExtendContextForFinalization. I'm testing running a workflow locally, and it uses ExtendContextForFinalization to cleanup the runner. The logs are pretty unusable because this is logged hundreds (thousands?) of times. How would you feel about just deleting the log and adding a comment to ExtendContextForFinalization? We're already manually manipulating the context at that point, it feels fair enough to me to have a disclaimer that the deadline is not valid

@bduffany
Copy link
Member Author

bduffany commented Apr 11, 2024

@maggie-lou this log hints at an actual bug because the deadline will be reported as effectively infinite even though it's not. I would like to fix these instances if you're seeing the debug log - do you mind locally adding debug.PrintStack() (from runtime/debug) just before the debug log in this file and sending me the stack trace?

@bduffany
Copy link
Member Author

bduffany commented Apr 11, 2024

I don't see a quick fix for the codepath that Maggie found so I went ahead and just removed this debug log for now. If this Deadline() issue comes up again we can think of an alternative solution

@bduffany bduffany changed the title Disable debug logs for contexts created with ToBackground() Disable debug logs in disconnectedContext.Deadline() Apr 11, 2024
@bduffany bduffany merged commit 1f88059 into master Apr 11, 2024
18 checks passed
@bduffany bduffany deleted the ctx-extend-fix branch April 11, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants