Add flag to skip Contains() check in bytestream.Write if file is small. #6358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdhollen
force-pushed
the
jh/2024-04-10_write-missing
branch
2 times, most recently
from
405e879
to
d42b7d0
Compare
jdhollen
force-pushed
the
jh/2024-04-10_write-missing
branch
from
d42b7d0
to
aa8d322
Compare
tylerwilliams
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writes are small, traces look like this:
small writes (which are most writes) should get a 75% drop in latency, and current AlreadyExists rates imply this shouldn't increase load.
Related issues: N/A