Improve vmexec RPC error handling #6363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
force-pushed
the
demystify-deadline-exceeded
branch
from
2a3518a
to
8e2f078
Compare
tylerwilliams
approved these changes
Apr 12, 2024
bduffany
force-pushed
the
demystify-deadline-exceeded
branch
from
8e2f078
to
4aabe67
Compare
bduffany
added a commit
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we return Unavailable in more places, and make sure to wrap errors in a few places so that we have more context.
Also add a temporary info-level log message in the case where the error returned is from the vmexec server (to help with debugging).
Related issues: N/A