Extend finalization deadline for pausing firecracker VMs #6364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maggie-lou
changed the title
bduffany
reviewed
Apr 12, 2024
enterprise/server/remote_execution/containers/firecracker/firecracker.go
Outdated
Show resolved
Hide resolved
maggie-lou
force-pushed
the
extend_finalization_ctx
branch
from
bd51c8e
to
56d7083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6345 fixed a bug where in many cases, ExtendContextForFinalization would extend the context deadline ~indefinitely (7 days, to be specific). Now that it's fixed, certain code paths are failing because the finalization deadlines we'd set are too short
P99 to pause a firecracker VM takes 1.5min. Setting the deadline to 3min to be safe (P95 frequently reaches 1.5min as well)
Related issues: N/A