-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Raft] Add a transaction janitor #6374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall this looks good -- just a few comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's kind of messy how DeleteTxnRecord and WriteTxnRecord are in the sender but called from the janitor. Could all of these txn coordinator methods be moved to a txncoordinator file, along with the janitor code?
|
enterprise/server/raft/txn/txn.go
Outdated
Sender() *sender.Sender | ||
} | ||
|
||
type TxnCoordinator struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: just call this Coordinator
Related issues:
https://github.com/buildbuddy-io/buildbuddy-internal/issues/3279
TxnRecord
and store it in meta range at different stages ofRunTxn
.stuck transactions unstuck.