Use block-based size for filecache entry size #6376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
force-pushed
the
filecache-real-size
branch
from
24c7157
to
0e8e27d
Compare
bduffany
changed the title
bduffany
force-pushed
the
filecache-real-size
branch
3 times, most recently
from
a9c77a3
to
e1ea841
Compare
bduffany
force-pushed
the
filecache-real-size
branch
from
e1ea841
to
ea9cf47
Compare
| } | ||
| // Stat always returns number of 512 byte blocks, regardless of the FS | ||
| // settings. | ||
| sizeOnDisk = info.Sys().(*syscall.Stat_t).Blocks * 512 |
There was a problem hiding this comment.
I'm guessing this doesn't work on Windows. I'm not sure what the status of Windows executors are, but we may need to special case this calculation for this to compile on Windows @sluongng
There was a problem hiding this comment.
Updated so that we continue to use the content size on windows for now until we can figure out something more accurate.
There was a problem hiding this comment.
Windows executor should be functional on HEAD. If you guys need to test something, please ping me on Slack.
bduffany
force-pushed
the
filecache-real-size
branch
from
7fb14a5
to
3563570
Compare
vadimberezniker
approved these changes
Apr 16, 2024
bduffany
force-pushed
the
filecache-real-size
branch
from
0c579e2
to
69ff563
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
AddFile, stat the file to get the number of blocks consumed by the file, and compute the size based on the number of blocks consumed, rather than the content stored in the blocks. The extrastat()syscall does not significantly affect performance according to benchmarks:A future improvement could be to also account for the file metadata, not just the file contents. But just computing the block-based size should be good enough for now.
Related issues: