[RB] Stream large writes to prevent grpc errors #6377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maggie-lou
force-pushed
the
upload_big_file
branch
from
01d1f69
to
07bd570
Compare
maggie-lou
changed the title
bduffany
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ci runner bundle has gotten too large, so we were seeing errors like
ResourceExhausted desc = grpc: received message larger than max (50464990 vs. 50000000)when trying to upload it to the cache. Use a bytestream write instead to handle large blobs.Customers have previously reported similar errors, so hopefully this helps there too: https://buildbuddy-corp.slack.com/archives/C057TAUAQ7P/p1701803746816029?thread_ts=1701800129.129309&cid=C057TAUAQ7P
This PR also changes the hosted runner to use blake3 to generate digests. Hopefully this will help performance with these huge blobs
Related issues: Fixes https://github.com/buildbuddy-io/buildbuddy-internal/issues/3263