Temporarily make VM logging opt-in only #6385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
force-pushed
the
fc-logging-fix
branch
2 times, most recently
from
07f781a
to
73e481b
Compare
bduffany
force-pushed
the
fc-logging-fix
branch
from
73e481b
to
fb9e173
Compare
maggie-lou
reviewed
Apr 17, 2024
| @@ -449,6 +449,7 @@ func (p *Provider) New(ctx context.Context, props *platform.Properties, task *re | |||
| NumCpus: numCPUs, | |||
| MemSizeMb: int64(math.Max(1.0, float64(sizeEstimate.GetEstimatedMemoryBytes())/1e6)), | |||
| ScratchDiskSizeMb: int64(float64(sizeEstimate.GetEstimatedFreeDiskBytes()) / 1e6), | |||
| EnableLogging: platform.IsTrue(platform.FindEffectiveValue(task.GetExecutionTask(), "debug-enable-vm-logs")), | |||
There was a problem hiding this comment.
nit: I'm okay with you merging this now so it makes it into the release, but it would be nice if we pulled this from props so there's a more standardized way of propagating platform data
maggie-lou
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging within the VM (
log.Infofetc.) occasionally seems to cause hanging after the VM is resumed from snapshot. Make logging opt-in for now, includingdockerdlogs, until we find a solution. Keep kernel logs around since these seem fine.Related issues: #6385