Roll-forward "Fix ext4 DirectoryToImageAutoSize not working for some images (#6380)" #6402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
force-pushed
the
rollforward-disksize
branch
4 times, most recently
from
ba7a7c6
to
2386581
Compare
vadimberezniker
approved these changes
Apr 18, 2024
bduffany
force-pushed
the
rollforward-disksize
branch
from
2386581
to
584b07d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR #6380
The fixes are in this commit
lstatinstead ofstatsincestatcan fail on "dangling" symlinks (symlink with a target that does not exist)DirectoryToImageAutoSize,if err != nil { return nil }should beif err != nil { return err }ext4_testruns on CI and add regression tests for both of the above issuesRelated issues: N/A