printlog/compact: support sorting SpawnExec #6406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
reviewed
Apr 18, 2024
sluongng
force-pushed
the
sluongng/stable-sort
branch
from
3d6ce3f
to
0005a7a
Compare
sluongng
changed the title
sluongng
force-pushed
the
sluongng/stable-sort
branch
2 times, most recently
from
1ca76a6
to
23ef913
Compare
sluongng
force-pushed
the
sluongng/stable-sort
branch
from
23ef913
to
0b4013d
Compare
fmeum
approved these changes
Apr 18, 2024
bduffany
approved these changes
Apr 18, 2024
sluongng
force-pushed
the
sluongng/stable-sort
branch
2 times, most recently
from
8dc851e
to
b5367a8
Compare
integration test
sluongng
force-pushed
the
sluongng/stable-sort
branch
from
b5367a8
to
3ff9b84
Compare
|
@bduffany FYI I am excluding the |
fmeum
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement StableSort algorithm that lets us sort SpawnExec in a topological order based on the artifacts outputs -> inputs relationship between them.
Port the test suite from Java to validate the algorithm.