Basic CacheProxy Server #6430
Basic CacheProxy Server #6430
Conversation
| if err != nil { | ||
| return err | ||
| } | ||
| stream.Send(rsp) |
There was a problem hiding this comment.
are we ignoring the error returned by stream.Send?
There was a problem hiding this comment.
whoops, fixed
| } | ||
|
|
||
| func (s *ByteStreamServerProxy) Write(stream bspb.ByteStream_WriteServer) error { | ||
| remote_stream, err := s.remote_cache.Write(stream.Context()) |
There was a problem hiding this comment.
s/remote_stream/remoteStream/g
| local_cache interfaces.Cache | ||
| remote_cache repb.ActionCacheClient |
There was a problem hiding this comment.
nit: camelCase var names instead of c_style
There was a problem hiding this comment.
think i got 'em all
| listen = flag.String("listen", "0.0.0.0", "The interface to listen on (default: 0.0.0.0)") | ||
| port = flag.Int("port", 8080, "The port to listen for HTTP traffic on") | ||
| sslPort = flag.Int("ssl_port", 8081, "The port to listen for HTTPS traffic on") | ||
| internalHTTPPort = flag.Int("internal_http_port", 0, "The port to listen for internal HTTP traffic") |
There was a problem hiding this comment.
dumb question: what is this used for? Could we remove it and the whole block where we use it below?
| if err != nil { | ||
| return err | ||
| } | ||
| stream.Send(rsp) |
| if err != nil { | ||
| return err | ||
| } | ||
| env.SetGRPCSServer(grpcsServer) | ||
| return nil | ||
| } | ||
|
|
||
| func RegisterInternalGRPCServer(env *real_environment.RealEnv, regServices RegisterServices) error { | ||
| func RegisterInternalGRPCServer(env *real_environment.RealEnv, config GRPCServerConfig, regServices RegisterServices) error { |
There was a problem hiding this comment.
I find these Register functions that take a closure really confusing. Not your fault obvi :) They are not very idiomatic and are hard to use.
Maybe we can find a way to remove them?
There was a problem hiding this comment.
#6442 (i'll rebase this on that if it gets in relatively quickly)
iain-macdonald
force-pushed
the
cache_proxy_server_1
branch
from
9f7f544
to
f99992c
Compare
This PR introduces a new cache_proxy server (
//enterprise/server/cmd/cache_proxy) that proxies the ActionCache, ByteStream, Capabilities, and ContentAddressableStorage services to the specified backend server. It authenticates with the backing cache by forwarding the provided API Key along. This server is currently running in dev atgrpcs://proxy.buildbudd.dev, you can build against it by running something like:Next steps are to add a local cache, better auth, and then try routing executor-to-app traffic through the proxy.
I went back and forth over whether to switch the gRPC server configuration to use the Builder pattern instead of just adding a new configuration option, but chose the latter because it's a little simpler.
Related issues: N/A