Fix release.py running docker images instead of just building #6439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
requested review from
iain-macdonald,
tylerwilliams and
vadimberezniker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6416 changed the behavior of
release.pyto build the docker images withbazel runbut then push them with thedockerCLI, rather than using thecontainer_pushtargets.When calling
bazel runon the BuildBuddy servergo_imagetargets though, it actually runs the server image after building it. This differs fromcontainer_imagewhich just builds and tags the image. This behavior causesrelease.pyto get stuck running the server.To fix this issue, this PR changes the
buildbuddy_imageserver targets (OSS and enterprise) to becontainer_imagetargets rather thango_imagetargets.Related issues: N/A