Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove error alerts when comments are posted, clean up some dead code #6456

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

jdhollen
Copy link
Member

Related issues: N/A

@jdhollen jdhollen marked this pull request as ready for review April 26, 2024 20:14
@jdhollen jdhollen changed the title remove random error alerts when posting comments remove error alerts when comments are posted, clean up some dead code Apr 26, 2024
Copy link
Contributor

@iain-macdonald iain-macdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to delete file_content too?

@jdhollen
Copy link
Member Author

did you mean to delete file_content too?

yup, it's replaced by file_content_monaco

Copy link
Contributor

@iain-macdonald iain-macdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Approval

@jdhollen jdhollen merged commit 7114737 into master Apr 26, 2024
19 checks passed
@jdhollen jdhollen deleted the jh/2024-04-26_remove-error-alerts branch April 26, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants