Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shade comments lighter when the current user has already replied #6458

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

jdhollen
Copy link
Member

@jdhollen jdhollen commented Apr 26, 2024

I don't think this is an exact match to the "familiar" behavior, but it seems close enough.

I'll be adding text to the file list about the number of unaddressed comments (when the author is viewing) + draft comments (everyone) in a separate PR.

Fixes buildbuddy-io/buildbuddy-internal/issues/3324 (this is the last issue i'll address as part of that bug, let's file individual bugs from now on, i'll add a tag)

Related issues: N/A

@jdhollen jdhollen marked this pull request as ready for review April 26, 2024 22:52
@jdhollen jdhollen merged commit 5cd408c into master Apr 29, 2024
19 checks passed
@jdhollen jdhollen deleted the jh/2024-04-26_less-yellow branch April 29, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants